Balkishan Kachawa

Lightning Component Best Practices PART 2

Posted on December 30, 2015

Hi All,

Few days before I wrote an article on best practices of Lightning Components. In that article I told you about best practices of Lightning Component Bundle(Controller, Helper, Renderer) and Events. Today I will tell you about best practices to create secure Lightning Components.

In Winter 16 release Salesforce introduced an important change to Lightning Component, In order to run Lightning Components in your org, you will be required to use the My Domain feature.

Why My Domain? At Salesforce, Trust is their number one value. The security team that reviews all changes to the Force.com platform have determined that requiring of My Domain will allow Salesforce to enact even better security around Lightning Components. And better security is good for everyone.

Because of this new feature insecurity is not neccessorily coming from Lightning Components but can come from JavaScript(Client Side) or Apex(Server Side). All the insecurities may come from JavaScript rather than from Lightning Component. Reason for this is the JavaScript from same domain can actually access,modify and read everything. You should follow below best practices to avoid insecurities from Client Side and Server Side. I tried to explore them.

Client Side

• When modifying the DOM, avoid the use of HTML rendering functions such as innerHTML or $().append(). Rather use component getters and setters whenever possible.

//Component1.cmp
<aura:component>
	<aura:attribute name="msg" type="String"></aura:attribute>
	<div><b>{!v.msg}</b></div>
</aura:component>

//Component1Helper.js
({
	changeValue : function(component) {
		component.set("v.msg","Changed value before Render"); // Modifying DOM using setter
	},
})

//Component1Renderer.js
({
	render: function(cmp, helper) {
	   console.log('render');
	   helper.changeValue(cmp); // Modifying DOM in renderer
	   return this.superRender()
	},
})

In above code I am modifying DOM using setter.

The DOM may only be modified in a renderer. Outside a renderer, the DOM is read-only. Suppose if you are trying to modify DOM in a controller than you are playing out side of the cycle of aura. If you do modification in controller the renderer will wipe all the DOM modification and you will end up with no result.

In above code I am modifying DOM in renderer.

Note : JS code within a component can only modify DOM elements belonging to the component. For example, it cannot modify document head or directly access the DOM element belonging to another component. In order to modify a parent or sibling component, an event should be passed to the target component. Child components should only be accessed via their attributes, and not by accessing the DOM of the child component directly.

• To change styles dynamically, use $A.util.toggleClass() or $A.util.addClass(),$A.util.removeClass().
  Use $A.util.toggleClass() for component instead of a DOM element.

//toggleCss.cmp
<aura:component>
	<div aura:id="changeIt">Change Me!</div><br />
	<ui:button press="{!c.applyCSS}" label="Add Style" />
	<ui:button press="{!c.removeCSS}" label="Remove Style" />
</aura:component>
//toggleCssController.js
({
	applyCSS: function(cmp, event) {
		var cmpTarget = cmp.find('changeIt');
		$A.util.addClass(cmpTarget, 'changeMe');
	},
	removeCSS: function(cmp, event) {
		var cmpTarget = cmp.find('changeIt');
		$A.util.removeClass(cmpTarget, 'changeMe');
	}
})
//toggleCss.css
.THIS.changeMe {
	background-color:yellow;
	width:200px;
}

• Use $A.getCallback() to wrap any code that accesses a component outside the normal rerendering lifecycle, such as in a setTimeout() or setInterval() call or in an ES6 Promise. $A.getCallback() preserves the current execution context and grants the correct access level to the asynchronous code. Otherwise, the framework loses context and only allows access to global resources.

window.setTimeout(
	$A.getCallback(function() {
		if (cmp.isValid()) {
			cmp.set("v.visible", true);
		}
	}), 5000
)

This sample sets the visible attribute on a component to true after a five-second delay.

• Avoid the use of inline javascript except when referencing JS controller methods.

<div onmouseover="myfunction" >foo</div> //bad
<div onmouseover="c.myControllerFunction" >foo</div> //OK

• Do not overwrite window or document functions.

window.onload = function () {
   //some code
}
document.write = function() {
   //some code
}

• Don’t use Script or Link tag to include JavaScript or CSS file. Instead of this use use the [ltng:require] aura component.

<link type='text/css' rel='stylesheet' href='YOUR_CSS_FILE.css' /> //bad
<script src="YOUR_JS_FILE.js"></script> //bad

<ltng:require styles="CSS FILE 1,CSS FILE 2,..." scripts="JS FILE 1,JS FILE 2,.."></ltng:require> //OK

• Avoid using absolute URL use relative URL with ‘/’ and encodeURL.
• Events may only be fired within a controller or component file, but not in a renderer. If you fire an event in renderer the event will go and call the controller again and controller will instantiate again,setup data again and call renderer again and cycle will repeat. This will end up with an infinite loop.
• Avoid using component. This component outputs value as unescaped HTML, which introduces the possibility of security vulnerabilities in your code. You must sanitize user input before rendering it unescaped, or you will create a cross-site scripting (XSS) vulnerability. Only use with trusted or sanitized sources of data.

Server Side

• All controller classes must have the with sharing keyword. There are no exceptions. In some cases, your code will need to elevate privileges beyond those of the logged in user.

public class DemoController() {  //Unsafe
    
    @AuraEnabled
    public static String getSummary() {
        //code
    }
}

public with sharing class DemoController() {  //safe
    
    @AuraEnabled
    public static String getSummary() {
        //code
    }
}

• CRUD/FLS permissions are not automatically enforced in lightning components or controllers, nor can you rely on lightning components to enforce security (as the client is under the control of the attacker, so all security checks must always be performed server-side). You must explicitly check for for isAccessible(), isUpdateable(), isCreateable(), isDeletable() prior to performing these operations on sObjects.

public with sharing class DemoController() {
    
    @AuraEnabled
    public static Contact getContact(String fieldName) { //safe
        if(Schema.SObjectType.Contact.fields.getMap().get('Name').getDescribe().isAccessible()){
			//code
		}
    }
}

Above best practices will help your Lightning Components in passing through security review of AppExchange.

Hope this will be helpful cheers!! 🙂